Remove 64-bit atomics in main crate#8037
Merged
Merged
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8037-remove-64-bit-atomics View snapshot changes at kitdiff |
kay-lambdadelta
force-pushed
the
remove-64-bit-atomics
branch
from
b350a93 to
b2c8b10
Compare
kay-lambdadelta
force-pushed
the
remove-64-bit-atomics
branch
from
66a3d11 to
b2c8b10
Compare
kay-lambdadelta
force-pushed
the
remove-64-bit-atomics
branch
from
b2c8b10 to
ac2eba2
Compare
lucasmerlin
approved these changes
Apr 14, 2026
lucasmerlin
left a comment
lucasmerlin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
Maybe we can also forbid the use of AtomicU64 with clippy so we don't regress on this in the future?
Contributor
Author
Something this would work I believe. disallowed-types = [
{ path = "std::sync::atomic::AtomicU64", reason = "AtomicU64 is not supported on many common platforms, use AtomicU32 or AtomicUsize instead" }
] |
emilk
changed the title
1 task
lucasmerlin
pushed a commit
that referenced
this pull request
Jun 25, 2026
This is a bit like my previous pr (<#8037>), but addresses the final bit of 64 bit atomic dependent code, the svg loader in the `egui_extras` crate. As with the previous pr, this improves egui's compatibility on platforms without 64 bit atomics. * Closes <#7692> * [x] I have followed the instructions in the PR template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the base egui crate to run on platforms without 64 bit atomics
Addresses Use
AtomicU32in place ofAtomicU64#7692, but does not address theegui_extrascrateI have followed the instructions in the PR template